Upgrade js-yaml [CROM-6825] #736
Conversation
| @@ -10,6 +10,7 @@ services: | |||
| service: jmui | |||
| command: ["npm", "run-script", "ng", "--", "serve", "--host", "jmui"] | |||
| volumes: | |||
| - /ui/src/assets/environments/ | |||
There was a problem hiding this comment.
Create a volume for the below config file to be mounted into. I only 60% understand why this was needed - it's related to the fact that ui/src is already separately mounted in the compose file this one inherits from. Without this, the mounted config file was always empty.
| FROM node | ||
| FROM node:14 | ||
|
|
||
| RUN apt-get update && apt-get -y install python |
There was a problem hiding this comment.
Explicitly install Python because otherwise it can't be found when needed during npm install.
There was a problem hiding this comment.
Can you either leave a comment or specify explicitly in the code whether this is python2 or python3?
It is confusing (and not your fault) that package managers/OSes use the same name even if they are installed concurrently!
| @@ -1,6 +1,8 @@ | |||
| # Note: This is the dockerfile for development purposes | |||
|
|
|||
| FROM node | |||
| FROM node:14 | |||
There was a problem hiding this comment.
Specify (downgrade) node version to fix C compilation errors (see here).
| FROM node | ||
| FROM node:14 | ||
|
|
||
| RUN apt-get update && apt-get -y install python |
There was a problem hiding this comment.
Can you either leave a comment or specify explicitly in the code whether this is python2 or python3?
It is confusing (and not your fault) that package managers/OSes use the same name even if they are installed concurrently!
Also made a few changes to get the development image working for me.