[TUIM-50] Update floating holidays for 2023 #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyuksel
changed the title
kyuksel
commented
Dec 11, 2022
| # Holiday dates specific to 2022 that will need to be updated next year | ||
| # as per https://intranet.broadinstitute.org/keywords/holiday-calendar | ||
| # Holiday dates specific to 2023 that will need to be updated towards the end of that year | ||
| # as per https://intranet.broadinstitute.org/faq/what-broads-holiday-schedule |
There was a problem hiding this comment.
The updated URL requires less clicks to go through holiday dates.
kyuksel
commented
Dec 11, 2022
| # and https://intranet.broadinstitute.org/hr/human-resources-policy-manual/time | ||
| HOLIDAYS=("12/23/2021" "01/17/2022" "02/21/2022" "04/18/2022" "05/30/2022" "06/20/2022" "07/01/2022" "07/04/2022" | ||
| "09/02/2022" "09/05/2022" "10/10/2022" "11/11/2022" "11/24/2022" "11/25/2022" "12/23/2022") | ||
| HOLIDAYS=("12/23/2022" "01/02/2023" "01/16/2023" "02/20/2023" "04/17/2023" "05/29/2023" "06/19/2023" "07/04/2023" |
There was a problem hiding this comment.
Starting with the last floating holiday of the previous year (2022 in this case) so we don't have to wait until Broad closes to merge the PR
MatthewBemis
approved these changes
Dec 11, 2022
nawatts
approved these changes
Dec 12, 2022
MatthewBemis
approved these changes
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://broadworkbench.atlassian.net/browse/TUIM-50
We don’t deploy to prod on Broad holidays, some of which float from year to year so we need to update them as per https://intranet.broadinstitute.org/faq/what-broads-holiday-schedule.