-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WX-1857] Methods Repository workflow details page improvements #5108
Conversation
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me.
Tested on PR environment, the two issues that seem most likely to cause complaints; namely 404s now display a proper message and page elements no longer interfere with selecting snapshots.
Jira Ticket: https://broadworkbench.atlassian.net/browse/WX-1857
Summary of changes:
What
namespace/name
method path is invalid, a "Could not display method" error page is shown, with the option to return to the methods list. (Compare to the existing "Could not display workspace" error page.)Why
Testing strategy
Select
component do not render directly underneath the main dropdown box in a unit test environment, unit tests were not able to be written for the dropdown fix. This change was manually tested only.Visual Aids
Invalid URL error handling and snapshot dropdown fix:
Screen.Recording.2024-09-30.at.1.29.12.PM.mov
Unexpected/network error while loading method snapshots list:
Unexpected/network error while loading individual snapshot details:
Note: The first 25 commits shown (up to
20214e9
) are from the branch off of which this branch was made. The diff is accurate to the work done for this PR.