[IA-5073] Fix a11y issue with clicking on a non-focusable element. #5115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cahrens
changed the title
1 task
jdcanas
approved these changes
Sep 27, 2024
|
lucymcnatt
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket: https://broadworkbench.atlassian.net/browse/IA-5073
I noticed this while working on the Puppeteer upgrade, as the newer version of Puppeteer did not want to click on a non-focusable element.
Adding a click handler to a div with no aria roles defined to indicate that the element is interactive is a major problem. Such an element is not keyboard focusable (cannot be reached via tab navigation), and thus is not accessible to people who cannot use a mouse.
Before (not focusable):
After (showing my browser keyboard-focus indication):