-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AN-160] Reorganize methods repository files #5155
Conversation
…anize_methods_repo_files since the same files edited in that branch will have to be moved
These 2 issues are preexisting and out of the scope of this PR to fix. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clearly an improvement and even if we rename user-visible stuff to "workflows", files can be called whatever IMO
Jira Ticket: https://broadworkbench.atlassian.net/browse/AN-160
Summary of changes:
Overview
Desired directory structure
src/pages/methods
directory contains page-level component files for the methods repo. (The previous equivalent directory,src/pages/workflows
, contained non-page-level components that should have been in the workflows functional area,src/workflows/...
, instead.)src/workflows/methods
directory is the subsection of thesrc/workflows
functional area that contains reusable components for the methods repo.src/libs/ajax/methods/methods-models.ts
, not in utils files in the pages directory or in a functional area.src/workflows/methods/workflows-acl-utils.ts
re-exports ACL types along with an existing ACL utility function, following the pattern fromsrc/workspaces/acl-utils.ts
.Why
Testing strategy