[CORE-368] Validate table rename #5272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
davidangb
reviewed
Mar 5, 2025
| format: { | ||
| pattern: '^(?!sys_)[a-z0-9_.-]*', | ||
| flags: 'i', | ||
| message: "Table name may only contain alphanumeric characters, underscores, dashes, and periods and cannot start with 'sys_'.", |
There was a problem hiding this comment.
table names cannot contain periods; they can start with sys_. Check the logic in Rawls as the source of truth for validation
kevinmarete
approved these changes
Mar 6, 2025
|
davidangb
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket: https://broadworkbench.atlassian.net/browse/CORE-368
Validates table name before allowing rename.
Note: compare to EntityUploader.js - the logic was copied from there but there appears to be some extra validation coming from the datatable provider. Does that need to be included in renaming as well?
Summary of changes:
What
Why
Testing strategy