[PF-1559] fix spotless & run 🏃🏻 #676
Conversation
|
Testing the GHA with an intentional lint failure. |
|
Can we make an entry in the spotless config here to skip the generated code? |
Great idea. That looks like the ticket. I'm stuck again though, because I don't understand why that annotation doesn't apply in this case for |
| @@ -1,5 +1,10 @@ | |||
| package bio.terra.workspace.service.resource.controlled.cloud.azure.storage; | |||
|
|
|||
| import static org.hamcrest.MatcherAssert.assertThat; | |||
There was a problem hiding this comment.
@jaycarlton This import ordering doesn't seem to be enforced by google-java-format, as when I reformat wit google-java-format in IntelliJ I don't get these changes. Therefore it seems that I need to run spotless locally also. What is the command to do that, and do you know if there is a way to set up IntelliJ's formatting to automatically use spotless?
There was a problem hiding this comment.
To run spotless, do ./gradlew spotlessApply after this is merged.
It's possible to set up IntelliJ so that it runs spotlessApply every time a file is saved. @melissachang is the only one I know who's done that.
Also, import ordering seems to work for me when I let IJ handle all the imports. I.e. I never manually add an import statement, and they seem to go to the right place FWIW.
There was a problem hiding this comment.
Have Intellij run spotless on file save:
| @@ -12,11 +12,6 @@ for (task in TASKS_ONLY_IF_COMPILE_JAVA) { | |||
| task.dependsOn(compileJava.inputs.files) | |||
| // If compileJava runs, this must run after it (for the following to work). | |||
| task.mustRunAfter(compileJava) | |||
| // Don't run if compileJava didn't do any work. This is necessary because otherwise, these | |||
There was a problem hiding this comment.
Yeah, one fix was to make spotlessApply, etc, actually run, and the other was to avoid running it on generated code.
Remove an over-optimization that made
spotlessApplyand its ilk rarely actually run. The first file is the only manual change.