Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding nocache flag for dev commands #278

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Conversation

jt-dd
Copy link
Contributor

@jt-dd jt-dd commented Oct 9, 2024

Adding --no-cache for dev command: kubehound dev --ui --no-cache. The default behavior now is to use cache when building Docker images.

This avoid spending 10 minutes building the UI...

@jt-dd jt-dd requested a review from a team as a code owner October 9, 2024 11:37
Copy link
Contributor

@edznux-dd edznux-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you write why disabling the cache makes things faster? This is definitely counter intuitive haha.

I remember there's something weird going on here but I can't remeber what.

@jt-dd
Copy link
Contributor Author

jt-dd commented Oct 9, 2024

Can you write why disabling the cache makes things faster? This is definitely counter intuitive haha.

I remember there's something weird going on here but I can't remeber what.

Disabling the cache does not make things go faster. Changed the default behavior to using the cache. Before we were never using the cache.

@jt-dd jt-dd requested a review from edznux-dd October 9, 2024 12:45
@jt-dd jt-dd merged commit 5f215eb into main Oct 9, 2024
8 checks passed
@jt-dd jt-dd deleted the jt-dd/new-dev-nocache-flag branch October 9, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants