Fix local dev env with datadog #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edznux-dd
approved these changes
Oct 9, 2024
edznux-dd
reviewed
Oct 9, 2024
| env_file: | ||
| - kubehound.env | ||
| labels: | ||
| com.datadoghq.ad.logs: '[{"app": "grpc", "service": "kubehound"}]' |
There was a problem hiding this comment.
seems weird to have app:grpc tbh
There was a problem hiding this comment.
(app:kubehound would seem more logical, or kubehound-ingestor if you want (i would rather have the service named kubehound-ingestor and the app named kubehound)
There was a problem hiding this comment.
I just put the name of container for the app. Same as all the others labels.
This is only for local dev anyway.
Only the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix local dev by adding the correct docker label.