-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
only-one-copy-in-graph-per-cluster #286
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is the Clean
function called, I see the interface and its implementation defined but never called?
Are you expecting to do that somewhere else?
@@ -145,3 +145,29 @@ func (jgp *JanusGraphProvider) Close(ctx context.Context) error { | |||
|
|||
return nil | |||
} | |||
|
|||
// Raw returns a handle to the underlying provider to allow implementation specific operations e.g graph queries. | |||
func (jgp *JanusGraphProvider) Clean(ctx context.Context, cluster string) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit for later: it would be great to have a trace for this. I have no intuition on how long it takes.
…ub.com/DataDog/kubehound into jt-dd/only-one-copy-in-graph-per-cluster
…only-one-copy-in-graph-per-cluster
Only keeping the last version of an ingested cluster. The previous versions are deleted (graph and mongo data).