Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix role-bind attack #299

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Fix role-bind attack #299

merged 2 commits into from
Dec 3, 2024

Conversation

jt-dd
Copy link
Contributor

@jt-dd jt-dd commented Dec 2, 2024 •
edited
Loading

The role-bind attack is linking permission accross clusters which leads to false positive. Restraining role-bind to same cluster/run_id.

Fixing also nonLargeClusterOptimization for pod_* attacks.

@jt-dd jt-dd marked this pull request as ready for review December 2, 2024 16:57
@jt-dd jt-dd requested a review from a team as a code owner December 2, 2024 16:57
@jt-dd jt-dd merged commit 7dd7f32 into main Dec 3, 2024
8 checks passed
@jt-dd jt-dd deleted the jt-dd/fix-role-bind-attack branch December 3, 2024 09:02
@BrewTestBot BrewTestBot mentioned this pull request Dec 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zenithar Zenithar Zenithar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jt-dd @Zenithar