example of post-processor to have integer CPU #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbenque
force-pushed
the
david.benque/poc-cpu-as-integer
branch
from
e3d2622
to
12ee968
Compare
Base automatically changed from
david.benque/reco-post-processing
to
datadog-master-vpa
November 28, 2022 14:23
iksaif
reviewed
Nov 29, 2022
| @@ -57,6 +57,9 @@ var ( | |||
| ctrPodNameLabel = flag.String("container-pod-name-label", "pod_name", `Label name to look for container pod names`) | |||
| ctrNameLabel = flag.String("container-name-label", "name", `Label name to look for container names`) | |||
| vpaObjectNamespace = flag.String("vpa-object-namespace", apiv1.NamespaceAll, "Namespace to search for VPA objects and pod stats. Empty means all namespaces will be used.") | |||
|
|
|||
| // recommendation post processor flags | |||
| postProcessorCPUasInteger = flag.Bool("recommendation-post-processor-cpu-as-integer-enabled", false, `Enable recommendation post process to have CPU as integer if requested by user in VPA object`) | |||
There was a problem hiding this comment.
I think this should be a list of pre processors instead
iksaif
reviewed
Nov 29, 2022
| // vpa-post-processor.kubernetes.io/{containerName}_integerCPU=true | ||
|
|
||
| vpaPostProcessorPrefix = "vpa-post-processor.kubernetes.io/" | ||
| vpaPostProcessorIntegerCPUSuffix = "_integerCPU" |
iksaif
reviewed
Nov 29, 2022
| apiv1 "k8s.io/api/core/v1" | ||
| vpa_types "k8s.io/autoscaler/vertical-pod-autoscaler/pkg/apis/autoscaling.k8s.io/v1" | ||
| "k8s.io/autoscaler/vertical-pod-autoscaler/pkg/recommender/model" | ||
| "math" |
iksaif
reviewed
Nov 29, 2022
| if resourceName != apiv1.ResourceCPU { | ||
| continue | ||
| } | ||
| v := float64(recommended.MilliValue()) / 1000 |
iksaif
reviewed
Nov 29, 2022
|
|
||
| // extractContainerName return the container name for the feature based on annotation key | ||
| // if the return value is empty that means that the key does not match | ||
| func extractContainerName(key, prefix, suffix string) string { |
There was a problem hiding this comment.
This is likely to be re-used and should be in a shared module no ?
dbenque
force-pushed
the
datadog-master-vpa
branch
from
52c0e1a
to
e608038
Compare
|
Merged upstream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which component this PR applies to?
vertical-pod-autoscaler/recommender
What type of PR is this?
/kind feature
What this PR does / why we need it:
It introduces a recommendation post processor that allows users to have a CPU integer as recommendation.
Thanks to that it is now possible to VPA for application using static CPU allocation
Which issue(s) this PR fixes:
Fixes kubernetes#5236
Special notes for your reviewer:
This PR is an example about how to use kubernetes#5239
Does this PR introduce a user-facing change?
It does not break any existing API.
With this implementation users activate the feature by adding an annotation their VPA objects:
vpa-post-processor.kubernetes.io/{containerName}_integerCPU=trueAdditional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
This post processor is optional. To run it in the recommender the command-line flag should be set:
--recommendation-post-processors="integerCPU,capping"