Use window.open observable

packages/rum-core/src/boot/startRum.spec.ts

@@ -62,6 +62,7 @@ function startRumStub(
   sessionManager: RumSessionManager,
   location: Location,
   domMutationObservable: Observable<void>,
+  windowOpenObservable: Observable<void>,
   locationChangeObservable: Observable<LocationChange>,
   pageStateHistory: PageStateHistory,
   reportError: (error: RawError) => void
@@ -74,6 +75,7 @@ function startRumStub(
     pageStateHistory,
     locationChangeObservable,
     domMutationObservable,
+    windowOpenObservable,
     () => ({
       context: {},
       user: {},
@@ -86,6 +88,7 @@ function startRumStub(
     configuration,
     location,
     domMutationObservable,
+    windowOpenObservable,
     locationChangeObservable,
     startFeatureFlagContexts(lifeCycle, createCustomerDataTracker(noop)),
     pageStateHistory,
@@ -114,6 +117,7 @@ describe('rum session', () => {
     lifeCycle = new LifeCycle()
     sessionManager = createRumSessionManagerMock().setId('42')
     const domMutationObservable = new Observable<void>()
+    const windowOpenObservable = new Observable<void>()
     const { locationChangeObservable } = setupLocationObserver()
 
     serverRumEvents = collectServerEvents(lifeCycle)
@@ -123,6 +127,7 @@ describe('rum session', () => {
       sessionManager,
       location,
       domMutationObservable,
+      windowOpenObservable,
       locationChangeObservable,
       mockPageStateHistory(),
       noop
@@ -165,6 +170,7 @@ describe('rum session keep alive', () => {
     clock = mockClock()
     sessionManager = createRumSessionManagerMock().setId('1234')
     const domMutationObservable = new Observable<void>()
+    const windowOpenObservable = new Observable<void>()
     const { locationChangeObservable } = setupLocationObserver()
 
     serverRumEvents = collectServerEvents(lifeCycle)
@@ -174,6 +180,7 @@ describe('rum session keep alive', () => {
       sessionManager,
       location,
       domMutationObservable,
+      windowOpenObservable,
       locationChangeObservable,
       mockPageStateHistory(),
       noop
@@ -229,6 +236,7 @@ describe('rum events url', () => {
   function setupViewUrlTest() {
     const sessionManager = createRumSessionManagerMock().setId('1234')
     const domMutationObservable = new Observable<void>()
+    const windowOpenObservable = new Observable<void>()
     const locationSetupResult = setupLocationObserver('http://foo.com/')
     changeLocation = locationSetupResult.changeLocation
 
@@ -238,6 +246,7 @@ describe('rum events url', () => {
       sessionManager,
       locationSetupResult.fakeLocation,
       domMutationObservable,
+      windowOpenObservable,
       locationSetupResult.locationChangeObservable,
       mockPageStateHistory(),
       noop

packages/rum-core/src/boot/startRum.ts

@@ -21,6 +21,7 @@ import {
   ExperimentalFeature,
 } from '@datadog/browser-core'
 import { createDOMMutationObservable } from '../browser/domMutationObservable'
+import { createWindowOpenObservable } from '../browser/windowOpenObservable'
 import { startRumAssembly } from '../domain/assembly'
 import { startInternalContext } from '../domain/contexts/internalContext'
 import { LifeCycle, LifeCycleEventType } from '../domain/lifeCycle'
@@ -125,6 +126,7 @@ export function startRum(
   }
 
   const domMutationObservable = createDOMMutationObservable()
+  const windowOpenObservable = createWindowOpenObservable()
   const locationChangeObservable = createLocationChangeObservable(configuration, location)
   const pageStateHistory = startPageStateHistory(configuration)
   const {
@@ -141,6 +143,7 @@ export function startRum(
     pageStateHistory,
     locationChangeObservable,
     domMutationObservable,
+    windowOpenObservable,
     getCommonContext,
     reportError
   )
@@ -160,6 +163,7 @@ export function startRum(
     configuration,
     location,
     domMutationObservable,
+    windowOpenObservable,
     locationChangeObservable,
     featureFlagContexts,
     pageStateHistory,
@@ -233,6 +237,7 @@ export function startRumEventCollection(
   pageStateHistory: PageStateHistory,
   locationChangeObservable: Observable<LocationChange>,
   domMutationObservable: Observable<void>,
+  windowOpenObservable: Observable<void>,
   getCommonContext: () => CommonContext,
   reportError: (error: RawError) => void
 ) {
@@ -242,6 +247,7 @@ export function startRumEventCollection(
   const { addAction, actionContexts } = startActionCollection(
     lifeCycle,
     domMutationObservable,
+    windowOpenObservable,
     configuration,
     pageStateHistory
   )

packages/rum-core/src/browser/windowOpenObservable.ts

@@ -0,0 +1,9 @@
+import { instrumentMethod, Observable } from '@datadog/browser-core'
+
+export function createWindowOpenObservable() {
+  const observable = new Observable<void>()
+  instrumentMethod(window, 'open', () => {
+    observable.notify()
+  })
+  return observable
+}

packages/rum-core/src/domain/action/actionCollection.spec.ts

@@ -17,10 +17,12 @@ describe('actionCollection', () => {
 
   beforeEach(() => {
     const domMutationObservable = new Observable<void>()
+    const windowOpenObservable = new Observable<void>()
 
     ;({ addAction } = startActionCollection(
       lifeCycle,
       domMutationObservable,
+      windowOpenObservable,
       mockRumConfiguration(),
       basePageStateHistory
     ))

packages/rum-core/src/domain/action/actionCollection.ts

@@ -37,6 +37,7 @@ export type AutoAction = ClickAction
 export function startActionCollection(
   lifeCycle: LifeCycle,
   domMutationObservable: Observable<void>,
+  windowOpenObservable: Observable<void>,
   configuration: RumConfiguration,
   pageStateHistory: PageStateHistory
 ) {
@@ -46,7 +47,12 @@ export function startActionCollection(
 
   let actionContexts: ActionContexts = { findActionId: noop as () => undefined }
   if (configuration.trackUserInteractions) {
-    actionContexts = trackClickActions(lifeCycle, domMutationObservable, configuration).actionContexts
+    actionContexts = trackClickActions(
+      lifeCycle,
+      domMutationObservable,
+      windowOpenObservable,
+      configuration
+    ).actionContexts
   }
 
   return {

packages/rum-core/src/domain/action/trackClickActions.spec.ts

@@ -44,6 +44,7 @@ function eventsCollector<T>() {
 describe('trackClickActions', () => {
   let lifeCycle: LifeCycle
   let domMutationObservable: Observable<void>
+  let windowOpenObservable: Observable<void>
   let clock: Clock
 
   const { events, pushEvent } = eventsCollector<ClickAction>()
@@ -58,6 +59,7 @@ describe('trackClickActions', () => {
     const trackClickActionsResult = trackClickActions(
       lifeCycle,
       domMutationObservable,
+      windowOpenObservable,
       mockRumConfiguration(partialConfig)
     )
 
@@ -72,6 +74,7 @@ describe('trackClickActions', () => {
     lifeCycle = new LifeCycle()
     clock = mockClock()
     domMutationObservable = new Observable<void>()
+    windowOpenObservable = new Observable<void>()
 
     button = document.createElement('button')
     button.type = 'button'

packages/rum-core/src/domain/action/trackClickActions.ts

@@ -64,6 +64,7 @@ export const ACTION_CONTEXT_TIME_OUT_DELAY = 5 * ONE_MINUTE // arbitrary
 export function trackClickActions(
   lifeCycle: LifeCycle,
   domMutationObservable: Observable<void>,
+  windowOpenObservable: Observable<void>,
   configuration: RumConfiguration
 ) {
   const history: ClickActionIdHistory = createValueHistory({ expireDelay: ACTION_CONTEXT_TIME_OUT_DELAY })
@@ -81,12 +82,13 @@ export function trackClickActions(
     hadActivityOnPointerDown: () => boolean
   }>(configuration, {
     onPointerDown: (pointerDownEvent) =>
-      processPointerDown(configuration, lifeCycle, domMutationObservable, pointerDownEvent),
+      processPointerDown(configuration, lifeCycle, domMutationObservable, pointerDownEvent, windowOpenObservable),
     onPointerUp: ({ clickActionBase, hadActivityOnPointerDown }, startEvent, getUserActivity) => {
       startClickAction(
         configuration,
         lifeCycle,
         domMutationObservable,
+        windowOpenObservable,
         history,
         stopObservable,
         appendClickToClickChain,
@@ -131,7 +133,8 @@ function processPointerDown(
   configuration: RumConfiguration,
   lifeCycle: LifeCycle,
   domMutationObservable: Observable<void>,
-  pointerDownEvent: MouseEventOnElement
+  pointerDownEvent: MouseEventOnElement,
+  windowOpenObservable: Observable<void>
 ) {
   const nodePrivacyLevel = configuration.enablePrivacyForActionName
     ? getNodePrivacyLevel(pointerDownEvent.target, configuration.defaultPrivacyLevel)
@@ -148,6 +151,7 @@ function processPointerDown(
   waitPageActivityEnd(
     lifeCycle,
     domMutationObservable,
+    windowOpenObservable,
     configuration,
     (pageActivityEndEvent) => {
       hadActivityOnPointerDown = pageActivityEndEvent.hadActivity
@@ -164,6 +168,7 @@ function startClickAction(
   configuration: RumConfiguration,
   lifeCycle: LifeCycle,
   domMutationObservable: Observable<void>,
+  windowOpenObservable: Observable<void>,
   history: ClickActionIdHistory,
   stopObservable: Observable<void>,
   appendClickToClickChain: (click: Click) => void,
@@ -183,6 +188,7 @@ function startClickAction(
   const { stop: stopWaitPageActivityEnd } = waitPageActivityEnd(
     lifeCycle,
     domMutationObservable,
+    windowOpenObservable,
     configuration,
     (pageActivityEndEvent) => {
       if (pageActivityEndEvent.hadActivity && pageActivityEndEvent.end < click.startClocks.timeStamp) {

packages/rum-core/src/domain/view/setupViewTest.specHelper.ts

@@ -14,6 +14,7 @@ interface ViewTrackingContext {
 
 export function setupViewTest({ lifeCycle, initialLocation }: ViewTrackingContext, initialViewOptions?: ViewOptions) {
   const domMutationObservable = new Observable<void>()
+  const windowOpenObservable = new Observable<void>()
   const configuration = mockRumConfiguration()
   const { locationChangeObservable, changeLocation } = setupLocationObserver(initialLocation)
 
@@ -42,6 +43,7 @@ export function setupViewTest({ lifeCycle, initialLocation }: ViewTrackingContex
     location,
     lifeCycle,
     domMutationObservable,
+    windowOpenObservable,
     configuration,
     locationChangeObservable,
     !configuration.trackViewsManually,

packages/rum-core/src/domain/view/trackViews.ts

@@ -93,6 +93,7 @@ export function trackViews(
   location: Location,
   lifeCycle: LifeCycle,
   domMutationObservable: Observable<void>,
+  windowOpenObservable: Observable<void>,
   configuration: RumConfiguration,
   locationChangeObservable: Observable<LocationChange>,
   areViewsTrackedAutomatically: boolean,
@@ -112,6 +113,7 @@ export function trackViews(
     const newlyCreatedView = newView(
       lifeCycle,
       domMutationObservable,
+      windowOpenObservable,
       configuration,
       location,
       loadingType,
@@ -188,6 +190,7 @@ export function trackViews(
 function newView(
   lifeCycle: LifeCycle,
   domMutationObservable: Observable<void>,
+  windowOpenObservable: Observable<void>,
   configuration: RumConfiguration,
   initialLocation: Location,
   loadingType: ViewLoadingType,
@@ -249,6 +252,7 @@ function newView(
   } = trackCommonViewMetrics(
     lifeCycle,
     domMutationObservable,
+    windowOpenObservable,
     configuration,
     scheduleViewUpdate,
     loadingType,

packages/rum-core/src/domain/view/viewCollection.spec.ts

@@ -80,13 +80,15 @@ describe('viewCollection', () => {
   ) {
     getReplayStatsSpy = jasmine.createSpy()
     const domMutationObservable = new Observable<void>()
+    const pageOpenObserable = new Observable<void>()
     const locationChangeObservable = new Observable<LocationChange>()
 
     const collectionResult = startViewCollection(
       lifeCycle,
       mockRumConfiguration(partialConfiguration),
       location,
       domMutationObservable,
+      pageOpenObserable,
       locationChangeObservable,
       mockFeatureFlagContexts(partialFeatureFlagContexts),
       mockPageStateHistory({

packages/rum-core/src/domain/view/viewCollection.ts

@@ -18,6 +18,7 @@ export function startViewCollection(
   configuration: RumConfiguration,
   location: Location,
   domMutationObservable: Observable<void>,
+  pageOpenObserable: Observable<void>,
   locationChangeObservable: Observable<LocationChange>,
   featureFlagContexts: FeatureFlagContexts,
   pageStateHistory: PageStateHistory,
@@ -34,6 +35,7 @@ export function startViewCollection(
     location,
     lifeCycle,
     domMutationObservable,
+    pageOpenObserable,
     configuration,
     locationChangeObservable,
     !configuration.trackViewsManually,

packages/rum-core/src/domain/view/viewMetrics/trackCommonViewMetrics.ts

@@ -20,6 +20,7 @@ export interface CommonViewMetrics {
 export function trackCommonViewMetrics(
   lifeCycle: LifeCycle,
   domMutationObservable: Observable<void>,
+  windowOpenObservable: Observable<void>,
   configuration: RumConfiguration,
   scheduleViewUpdate: () => void,
   loadingType: ViewLoadingType,
@@ -30,6 +31,7 @@ export function trackCommonViewMetrics(
   const { stop: stopLoadingTimeTracking, setLoadEvent } = trackLoadingTime(
     lifeCycle,
     domMutationObservable,
+    windowOpenObservable,
     configuration,
     loadingType,
     viewStart,

packages/rum-core/src/domain/view/viewMetrics/trackLoadingTime.spec.ts

@@ -21,6 +21,7 @@ describe('trackLoadingTime', () => {
   const lifeCycle = new LifeCycle()
   let clock: Clock
   let domMutationObservable: Observable<void>
+  let windowOpenObservable: Observable<void>
   let loadingTimeCallback: jasmine.Spy<(loadingTime: Duration) => void>
   let setLoadEvent: (loadEvent: Duration) => void
   let stopLoadingTimeTracking: () => void
@@ -29,6 +30,7 @@ describe('trackLoadingTime', () => {
     const loadingTimeTracking = trackLoadingTime(
       lifeCycle,
       domMutationObservable,
+      windowOpenObservable,
       mockRumConfiguration(),
       loadType,
       clocksOrigin(),
@@ -41,6 +43,7 @@ describe('trackLoadingTime', () => {
   beforeEach(() => {
     clock = mockClock()
     domMutationObservable = new Observable()
+    windowOpenObservable = new Observable()
     loadingTimeCallback = jasmine.createSpy<(loadingTime: Duration) => void>()
   })