👌 rename visibility_change to visibility_reason

DataDog · Jan 19, 2021 · 28be2f4 · 28be2f4
1 parent 557358b
commit 28be2f4
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/packages/rum-recorder/src/domain/segmentCollection.spec.ts b/packages/rum-recorder/src/domain/segmentCollection.spec.ts
@@ -98,15 +98,15 @@ describe('startSegmentCollection', () => {
       setPageVisibility('hidden')
       const { eventEmitter, sendCurrentSegment } = startSegmentCollection(CONTEXT)
       eventEmitter.dispatchEvent(createNewEvent(DOM_EVENT.VISIBILITY_CHANGE))
-      expect(sendCurrentSegment().creation_reason).toBe('visibility_change')
+      expect(sendCurrentSegment().creation_reason).toBe('visibility_hidden')
     })
 
     it('does not flush segment when the page become visible', () => {
       setPageVisibility('visible')
       const { eventEmitter, segmentFlushSpy, sendCurrentSegment } = startSegmentCollection(CONTEXT)
       eventEmitter.dispatchEvent(createNewEvent(DOM_EVENT.VISIBILITY_CHANGE))
       expect(segmentFlushSpy).not.toHaveBeenCalled()
-      expect(sendCurrentSegment().creation_reason).not.toBe('visibility_change')
+      expect(sendCurrentSegment().creation_reason).not.toBe('visibility_hidden')
     })
 
     it('flushes segment when the current segment deflate size reaches SEND_BEACON_BYTE_LENGTH_LIMIT', () => {

diff --git a/packages/rum-recorder/src/domain/segmentCollection.ts b/packages/rum-recorder/src/domain/segmentCollection.ts
@@ -89,7 +89,7 @@ export function doStartSegmentCollection(
     DOM_EVENT.VISIBILITY_CHANGE,
     () => {
       if (document.visibilityState === 'hidden') {
-        flushSegment('visibility_change')
+        flushSegment('visibility_hidden')
       }
     },
     { capture: true }

diff --git a/packages/rum-recorder/src/types.ts b/packages/rum-recorder/src/types.ts
@@ -42,4 +42,4 @@ export type CreationReason =
   | 'view_change'
   | 'session_renewed'
   | 'before_unload'
-  | 'visibility_change'
+  | 'visibility_hidden'