⚡ Ignore modulepreload and prefetch in link tags

DataDog · Jan 9, 2023 · 30633b6 · 30633b6
1 parent ac26b8d
commit 30633b6
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 2 deletions.
diff --git a/packages/rum/src/domain/record/privacy.spec.ts b/packages/rum/src/domain/record/privacy.spec.ts
@@ -203,6 +203,26 @@ describe('getNodeSelfPrivacyLevel', () => {
       html: '<script class="dd-privacy-allow">',
       expected: NodePrivacyLevel.ALLOW,
     },
+    {
+      msg: 'is a link with rel=preload and as=script',
+      html: '<link rel="preload" crossorigins as="script">',
+      expected: NodePrivacyLevel.IGNORE,
+    },
+    {
+      msg: 'is a link with rel=modulepreload and as=script',
+      html: '<link rel="modulepreload" as="script">',
+      expected: NodePrivacyLevel.IGNORE,
+    },
+    {
+      msg: 'is a link with rel=prefetch and as=script',
+      html: '<link rel="prefetch" as="script">',
+      expected: NodePrivacyLevel.IGNORE,
+    },
+    {
+      msg: 'is a link with rel=stylesheet and a not expected as=script',
+      html: '<link rel="stylesheet" as="script">',
+      expected: undefined,
+    },
 
     // Precedence
     {

diff --git a/packages/rum/src/domain/record/privacy.ts b/packages/rum/src/domain/record/privacy.ts
@@ -220,8 +220,8 @@ export function shouldIgnoreElement(element: Element): boolean {
   if (element.nodeName === 'LINK') {
     const relAttribute = getLowerCaseAttribute('rel')
     return (
-      // Scripts
-      (relAttribute === 'preload' && getLowerCaseAttribute('as') === 'script') ||
+      // Link as script - Ignore only when rel=preload, modulepreload or prefetch
+      (/preload|prefetch/i.test(relAttribute) && getLowerCaseAttribute('as') === 'script') ||
       // Favicons
       relAttribute === 'shortcut icon' ||
       relAttribute === 'icon'