Remove the feature flag from the foreground periods

DataDog · Sep 15, 2021 · d726c18 · d726c18
1 parent 844bbcb
commit d726c18
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 15 deletions.
diff --git a/packages/rum-core/src/boot/startRum.ts b/packages/rum-core/src/boot/startRum.ts
@@ -88,7 +88,7 @@ export function startRumEventCollection(
   getCommonContext: () => CommonContext
 ) {
   const parentContexts = startParentContexts(lifeCycle, session)
-  const foregroundContexts = startForegroundContexts(configuration)
+  const foregroundContexts = startForegroundContexts()
   const batch = startRumBatch(configuration, lifeCycle)
 
   startRumAssembly(applicationId, configuration, lifeCycle, session, parentContexts, getCommonContext)

diff --git a/packages/rum-core/src/domain/foregroundContexts.spec.ts b/packages/rum-core/src/domain/foregroundContexts.spec.ts
@@ -19,9 +19,8 @@ describe('foreground context', () => {
   beforeEach(() => {
     setupBuilder = setup()
       .withFakeClock()
-      .withConfiguration({ isEnabled: () => true })
-      .beforeBuild(({ configuration }) => {
-        foregroundContext = startForegroundContexts(configuration)
+      .beforeBuild(() => {
+        foregroundContext = startForegroundContexts()
         return foregroundContext
       })
   })

diff --git a/packages/rum-core/src/domain/foregroundContexts.ts b/packages/rum-core/src/domain/foregroundContexts.ts
@@ -1,6 +1,4 @@
 import {
-  Configuration,
-  noop,
   addEventListener,
   DOM_EVENT,
   RelativeTime,
@@ -29,15 +27,7 @@ export interface ForegroundPeriod {
 
 let foregroundPeriods: ForegroundPeriod[] = []
 
-export function startForegroundContexts(configuration: Configuration): ForegroundContexts {
-  if (!configuration.isEnabled('track-foreground')) {
-    return {
-      isInForegroundAt: () => undefined,
-      selectInForegroundPeriodsFor: () => undefined,
-      stop: noop,
-    }
-  }
-
+export function startForegroundContexts(): ForegroundContexts {
   if (document.hasFocus()) {
     addNewForegroundPeriod()
   }