🐛 [RUM-2280] fix duplicated mutations when using Shadow DOM

DataDog · Dec 11, 2023 · db65956 · db65956
1 parent f611ff5
commit db65956
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/packages/rum/src/domain/record/record.spec.ts b/packages/rum/src/domain/record/record.spec.ts
@@ -311,6 +311,22 @@ describe('record', () => {
       expect(innerMutationData.isChecked).toBe(true)
     })
 
+    it('should record the change event inside a shadow root only once, regardless if the DOM is serialized multiple times', () => {
+      const radio = appendElement('<input type="radio"/>', createShadow()) as HTMLInputElement
+      startRecording()
+
+      recordApi.takeSubsequentFullSnapshot()
+
+      radio.checked = true
+      radio.dispatchEvent(createNewEvent('change', { target: radio, composed: false }))
+
+      const inputRecords = getEmittedRecords().filter(
+        (record) => record.type === RecordType.IncrementalSnapshot && record.data.source === IncrementalSource.Input
+      )
+
+      expect(inputRecords.length).toBe(1)
+    })
+
     it('should clean the state once the shadow dom is removed to avoid memory leak', () => {
       const shadowRoot = createShadow()
       appendElement('<div class="toto"></div>', shadowRoot)

diff --git a/packages/rum/src/domain/record/shadowRootsController.ts b/packages/rum/src/domain/record/shadowRootsController.ts
@@ -30,6 +30,9 @@ export const initShadowRootsController = (
 
   const shadowRootsController: ShadowRootsController = {
     addShadowRoot: (shadowRoot: ShadowRoot) => {
+      if (controllerByShadowRoot.has(shadowRoot)) {
+        return
+      }
       const { stop: stopMutationObserver, flush } = initMutationObserver(
         mutationCb,
         configuration,