-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Spec files included in npm packages #2221
Comments
Here is a good conversation about what to include within a package. I would argue that including |
Hi @bcaudan, thanks for the quick reply! I appreciate linking the past issue. Because source maps are included, we then need to bundle the |
Exactly! About spec files, cf #2224, they should be excluded in the next release. |
Thanks for the quick update! |
It's been released as part of v4.42.1 |
Describe the bug
.spec.ts
files are included in the packaged versions on NPM. I understand that/src
files are included for easy reference, but including the test files simply bloats the size of the package on the disk. Is there a compelling reason to continue to keep.spec.ts
in the package NPM versions of the packages?To Reproduce
Steps to reproduce the behavior:
@datadog/browser-rum
or@datadog/browser-logs
try on RunKit
.spec.ts
files includedScreenshot from RunKit showing that `.spec.ts` files are included
Expected behavior
Do not include
.spec.ts
files in the packaged/src
because it bloats the download size of the package from NPM. We need to be conscious of the fact that disk space is finite and including bloat is wasteful.Thank you.
The text was updated successfully, but these errors were encountered: