-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 fix Could not load source file warning when bundling with Parcel #535
🐛 fix Could not load source file warning when bundling with Parcel #535
Conversation
Codecov Report
@@ Coverage Diff @@
## master #535 +/- ##
==========================================
- Coverage 88.40% 88.10% -0.31%
==========================================
Files 36 36
Lines 2286 2286
Branches 472 472
==========================================
- Hits 2021 2014 -7
- Misses 265 272 +7
Continue to review full report at Codecov.
|
@HHogg thank you for your PR! It will be released as part as the next version. |
No problem @BenoitZugmeyer and thanks for merging so quickly. Do you have a rough idea when this will be released? (It's a ticket in our sprint, which is now in the blocked column 🙃) |
Ha, nothing is preventing us to make a small patch release for this. I'll work on this tomorrow! |
This has been released in 1.20.1. Thanks again! |
Thanks for sorting this out so quickly @BenoitZugmeyer. |
Motivation
The package is building fine with Parcel, but it is leaving a lot of noisy logs due to the
src
folder being excluded from the published package.You can replicate this like...
Which you'll see the follow warnings.
Changes
Changes the NPM ignore files to include the src folder.
Testing
Rerun the commands given above, but with the src folders and there will be no warnings.
I have gone over the contributing documentation.