Init tooling #1
Merged
Init tooling #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcaudan
force-pushed
the
bcaudan/init-tooling
branch
from
2eb2655 to
e72915e
Compare
sdeprez
reviewed
Feb 4, 2019
There was a problem hiding this comment.
A few comments:
- we use
yarnin Datadog so with ayarn.locknot apackage-lock.json - I'm not a fan of pre-commit hooks, specially if they're forced like that by the code. If a developer wants them, they can always add them but I don't think it should on by default
- Let's make it explicit on the config that's it
120max line and2spaces for indentation
sdeprez
suggested changes
Feb 4, 2019
sdeprez
approved these changes
Feb 5, 2019
bcaudan
added a commit
that referenced
this pull request
Dec 6, 2021
* Update the configuration section Update the configuration section to include details about how to configure Browser and Session Replay * Update packages/rum/README.md Co-authored-by: Kaylyn <kaylyn.sigler@datadoghq.com> * Update packages/rum/README.md Co-authored-by: Kaylyn <kaylyn.sigler@datadoghq.com> * Update packages/rum/README.md Co-authored-by: Kaylyn <kaylyn.sigler@datadoghq.com> * Update packages/rum/README.md Co-authored-by: Kaylyn <kaylyn.sigler@datadoghq.com> * Updated Browser docs * Doc Review #1 * 👌 add extra links + fix formatting * Doc Review #2 Co-authored-by: Kaylyn <kaylyn.sigler@datadoghq.com> Co-authored-by: Austin Lai <76412946+alai97@users.noreply.github.com> Co-authored-by: Bastien Caudan <bastien.caudan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.