Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [RUMF-994] Support intake v2 #1013

Merged
merged 6 commits into from
Aug 27, 2021
Merged

Conversation

amortemousque
Copy link
Contributor

@amortemousque amortemousque commented Aug 25, 2021

Motivation

Intake v2 API gives us more flexibility to structure Intake and network proxies, hence makes the ingest pipeline easier to operate and more reliable.

In order to be up to date, the RUM browser SDK is planning to support Intake v2.

Changes

  • Add a new configuration option intakeApiVersion?: 1 | 2
  • Implement intake v2 endpoint
  • Move configuration logic in configuration folder

Testing

Local, Unit


I have gone over the contributing documentation.

@amortemousque amortemousque requested a review from a team as a code owner August 25, 2021 08:37
@amortemousque amortemousque changed the title ✨ Support intake v2 ✨ [RUMF-994] Support intake v2 Aug 25, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2021

Codecov Report

Merging #1013 (1a25d2e) into main (1477bbe) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1013      +/-   ##
==========================================
+ Coverage   89.02%   89.10%   +0.07%     
==========================================
  Files          86       87       +1     
  Lines        4119     4129      +10     
  Branches      946      947       +1     
==========================================
+ Hits         3667     3679      +12     
+ Misses        452      450       -2     
Impacted Files Coverage Δ
packages/core/src/domain/configuration.ts 90.00% <100.00%> (+3.33%) ⬆️
packages/core/src/domain/endpointBuilder.ts 100.00% <100.00%> (ø)
packages/core/src/domain/transportConfiguration.ts 100.00% <100.00%> (ø)
packages/core/src/tools/timeUtils.ts 93.93% <0.00%> (+3.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1477bbe...1a25d2e. Read the comment docs.

@amortemousque amortemousque force-pushed the aymeric/support-intake-v2 branch from 9bdca58 to 49f97e8 Compare August 26, 2021 09:16
@amortemousque amortemousque force-pushed the aymeric/support-intake-v2 branch from 49f97e8 to 561f1a9 Compare August 26, 2021 09:24
@amortemousque amortemousque force-pushed the aymeric/support-intake-v2 branch from 5b04d1f to fbfd48c Compare August 26, 2021 12:00
packages/core/src/domain/endpointBuilder.ts Outdated Show resolved Hide resolved
packages/core/src/domain/endpointBuilder.ts Outdated Show resolved Hide resolved
packages/core/src/domain/endpointBuilder.ts Outdated Show resolved Hide resolved
packages/core/src/domain/endpointBuilder.ts Outdated Show resolved Hide resolved
packages/core/src/domain/transportConfiguration.ts Outdated Show resolved Hide resolved
packages/core/src/domain/endpointBuilder.ts Outdated Show resolved Hide resolved
packages/core/src/domain/endpointBuilder.ts Outdated Show resolved Hide resolved
packages/core/src/domain/endpointBuilder.ts Outdated Show resolved Hide resolved
@amortemousque amortemousque merged commit e1af41c into main Aug 27, 2021
@bcaudan bcaudan deleted the aymeric/support-intake-v2 branch September 13, 2021 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants