-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ [RUMF-994] Support intake v2 #1013
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1013 +/- ##
==========================================
+ Coverage 89.02% 89.10% +0.07%
==========================================
Files 86 87 +1
Lines 4119 4129 +10
Branches 946 947 +1
==========================================
+ Hits 3667 3679 +12
+ Misses 452 450 -2
Continue to review full report at Codecov.
|
amortemousque
force-pushed
the
aymeric/support-intake-v2
branch
from
August 26, 2021 09:16
9bdca58
to
49f97e8
Compare
amortemousque
force-pushed
the
aymeric/support-intake-v2
branch
from
August 26, 2021 09:24
49f97e8
to
561f1a9
Compare
amortemousque
force-pushed
the
aymeric/support-intake-v2
branch
from
August 26, 2021 12:00
5b04d1f
to
fbfd48c
Compare
BenoitZugmeyer
approved these changes
Aug 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Intake v2 API gives us more flexibility to structure Intake and network proxies, hence makes the ingest pipeline easier to operate and more reliable.
In order to be up to date, the RUM browser SDK is planning to support Intake v2.
Changes
intakeApiVersion?: 1 | 2
Testing
Local, Unit
I have gone over the contributing documentation.