Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 MutationObserver bug fix for privacy level #1038

Merged
merged 6 commits into from
Sep 8, 2021

Conversation

jagracey
Copy link
Contributor

@jagracey jagracey commented Sep 7, 2021

Motivation

Noticed a bug on an internal session replay where a text node was treated with the wrong privacy level.
The text node was masked by default instead of allowed- which turns out to be a good fail safe for "private by default"👍.

Changes

Testing

Adds a new test to catch in the future.


I have gone over the contributing documentation.

@jagracey jagracey requested a review from a team as a code owner September 7, 2021 15:01
@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2021

Codecov Report

Merging #1038 (540a6dd) into main (c24c0ff) will decrease coverage by 0.01%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1038      +/-   ##
==========================================
- Coverage   88.95%   88.93%   -0.02%     
==========================================
  Files          88       88              
  Lines        4163     4166       +3     
  Branches      957      958       +1     
==========================================
+ Hits         3703     3705       +2     
- Misses        460      461       +1     
Impacted Files Coverage Δ
packages/rum/src/domain/record/mutationObserver.ts 95.65% <75.00%> (-0.65%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c24c0ff...540a6dd. Read the comment docs.

@jagracey jagracey merged commit 7440e21 into main Sep 8, 2021
@jagracey jagracey deleted the john.gracey/privacy-bugfix branch September 8, 2021 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants