✨ Discard long FCP and LCP #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amortemousque
force-pushed
the
aymeric/discard-long-FCP-and-LCP
branch
from
bd90dc2 to
dd79696
Compare
amortemousque
force-pushed
the
aymeric/discard-long-FCP-and-LCP
branch
from
dd79696 to
f9ef3d1
Compare
Codecov Report
@@ Coverage Diff @@
## main #1045 +/- ##
=======================================
Coverage 89.01% 89.02%
=======================================
Files 87 87
Lines 4134 4135 +1
Branches 950 952 +2
=======================================
+ Hits 3680 3681 +1
Misses 454 454
Continue to review full report at Codecov.
|
bcaudan
reviewed
Sep 14, 2021
| @@ -136,6 +136,16 @@ describe('trackFirstContentfulPaint', () => { | |||
| lifeCycle.notify(LifeCycleEventType.PERFORMANCE_ENTRY_COLLECTED, FAKE_PAINT_ENTRY) | |||
| expect(fcpCallback).not.toHaveBeenCalled() | |||
| }) | |||
|
|
|||
| it('should not be present if it happens after 10 minutes', () => { | |||
There was a problem hiding this comment.
why?
it could be more interesting to indicate what we are trying to achieve, meaning discarding timings reported after a long time.
| @@ -76,7 +77,8 @@ export function trackFirstContentfulPaint(lifeCycle: LifeCycle, callback: (fcp: | |||
| if ( | |||
| entry.entryType === 'paint' && | |||
| entry.name === 'first-contentful-paint' && | |||
| entry.startTime < firstHidden.timeStamp | |||
| entry.startTime < firstHidden.timeStamp && | |||
| entry.startTime < 10 * ONE_MINUTE | |||
There was a problem hiding this comment.
we should extract this constant, explain its purpose and how it was chosen
bcaudan
approved these changes
Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
LCP and FCP reported after 10 minutes are meaningless therefore we discard them
Changes
Discard LCP and FCP reported after 10 min
Testing
Unit, Locally
I have gone over the contributing documentation.