Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [RUMF-1029] remove the limit on view.loading_time #1054

Merged
merged 4 commits into from
Sep 16, 2021

Conversation

BenoitZugmeyer
Copy link
Member

@BenoitZugmeyer BenoitZugmeyer commented Sep 15, 2021

Motivation

Remove limit on view.loading_time to avoid having a weird distribution chart in the UI

Changes

Testing

CI, manual


I have gone over the contributing documentation.

@BenoitZugmeyer BenoitZugmeyer marked this pull request as ready for review September 15, 2021 15:48
@BenoitZugmeyer BenoitZugmeyer requested a review from a team as a code owner September 15, 2021 15:48
@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2021

Codecov Report

Merging #1054 (401b370) into main (1c7d5e9) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1054      +/-   ##
==========================================
- Coverage   89.02%   89.01%   -0.01%     
==========================================
  Files          87       87              
  Lines        4135     4133       -2     
  Branches      952      951       -1     
==========================================
- Hits         3681     3679       -2     
  Misses        454      454              
Impacted Files Coverage Δ
.../src/domain/rumEventsCollection/view/trackViews.ts 97.91% <ø> (ø)
.../domain/rumEventsCollection/action/trackActions.ts 97.95% <100.00%> (+0.04%) ⬆️
...omain/rumEventsCollection/view/trackViewMetrics.ts 100.00% <100.00%> (ø)
.../domain/rumEventsCollection/view/viewCollection.ts 100.00% <100.00%> (ø)
...ackages/rum-core/src/domain/trackPageActivities.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c7d5e9...401b370. Read the comment docs.

@BenoitZugmeyer BenoitZugmeyer merged commit 0075fcb into main Sep 16, 2021
@BenoitZugmeyer BenoitZugmeyer deleted the benoit/remove-max-loading-time-for-views branch September 16, 2021 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants