Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [RUMF-1000] add a custom time parameter to addTiming #1079

Merged
merged 4 commits into from
Sep 28, 2021

Conversation

BenoitZugmeyer
Copy link
Member

Motivation

Allow users to pass a custom time parameter to addTiming. Particularly useful in async setups, see #1005

Changes

  • support relative and absolute times in view.addTiming
  • add custom timing parameter support

Testing

CI


I have gone over the contributing documentation.

@BenoitZugmeyer BenoitZugmeyer requested a review from a team as a code owner September 27, 2021 17:18
@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2021

Codecov Report

Merging #1079 (2d9bd99) into main (57ceab0) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1079      +/-   ##
==========================================
+ Coverage   89.16%   89.17%   +0.01%     
==========================================
  Files          90       90              
  Lines        4170     4174       +4     
  Branches      951      952       +1     
==========================================
+ Hits         3718     3722       +4     
  Misses        452      452              
Impacted Files Coverage Δ
packages/core/src/tools/timeUtils.ts 94.28% <100.00%> (+0.34%) ⬆️
packages/core/src/tools/utils.ts 87.14% <100.00%> (+0.06%) ⬆️
packages/rum-core/src/boot/rumPublicApi.ts 97.91% <100.00%> (ø)
.../src/domain/rumEventsCollection/view/trackViews.ts 97.89% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57ceab0...2d9bd99. Read the comment docs.

@bcaudan bcaudan merged commit 1dffcc2 into main Sep 28, 2021
@bcaudan bcaudan deleted the benoit/restore-add-timing-time-parameter branch September 28, 2021 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants