Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [RUMF-1021] clear cookie cache before expanding cookie #1080

Merged
merged 1 commit into from
Sep 28, 2021

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Sep 28, 2021

Motivation

Since logs and rum share the same session cookie, we can end up with a cached value with only the first product clearing the value of the second product.

ex:

first product session: logs=1
second product session: logs=1&rum=1
expand first product session: logs=1

Changes

Ensure that we read the up to date cookie value before overwriting it

Testing

unit


I have gone over the contributing documentation.

ensure that we read the up to date value before overwriting it
@bcaudan bcaudan requested a review from a team as a code owner September 28, 2021 11:53
@bcaudan bcaudan merged commit 57ceab0 into main Sep 28, 2021
@bcaudan bcaudan deleted the bcaudan/plan-part4 branch September 28, 2021 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants