🔊 [RUMF-1036] Add negative loading time internal monitoring #1095
Conversation
| actionDuration, | ||
| type: this.type, | ||
| name: this.name, | ||
| startClocks: this.startClocks, | ||
| endTime, |
There was a problem hiding this comment.
I'm not sure how this information will help you to understand what's going on. The startClocks.timeStamp will always be greater than endTime, which is the issue I know, but what could we deduce from that?
Maybe storing the "clock state" in endTime instead of a timestamp alone could help, we could maybe observe that comparing timestamps produces a negative time, but comparing relative times produces a positive time.
There was a problem hiding this comment.
Noted, thanks for the advice. I'll add the end clock state.
Codecov Report
@@ Coverage Diff @@
## main #1095 +/- ##
==========================================
- Coverage 89.11% 89.10% -0.02%
==========================================
Files 90 90
Lines 4190 4193 +3
Branches 954 955 +1
==========================================
+ Hits 3734 3736 +2
- Misses 456 457 +1
Continue to review full report at Codecov.
|
| debug: { | ||
| actionDuration, | ||
| type: this.type, | ||
| name: this.name, | ||
| startClocks: this.startClocks, | ||
| endClocks, | ||
| }, |
There was a problem hiding this comment.
what about adding currentDrift too?
to see if it can be related somehow
Motivation
Some views and actions have a negative loading time.
Because it happens more often on actions, this PR only adds internal monitoring to them.
The first step is to identify if this behaviour comes from
waitIdlePageActivity.Changes
Add internal monitoring on actions with negative loading time
Testing
I have gone over the contributing documentation.