Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [RUMF-1021] fix regression on renew session #1096

Merged
merged 1 commit into from
Oct 1, 2021
Merged

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Sep 30, 2021

Motivation

monitoring code introduced by #1091 can prevent session to be renewed by overwriting the in memory session id.

Changes

Overwrite in memory session id only in expandOrRenewSession

Testing

local, staging


I have gone over the contributing documentation.

@bcaudan bcaudan changed the title Do not update memory cache by default during consistency check 🐛 [RUMF-1021] fix regression on renew session Sep 30, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #1096 (8c7bc0b) into main (32a5f92) will decrease coverage by 0.02%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1096      +/-   ##
==========================================
- Coverage   89.14%   89.11%   -0.03%     
==========================================
  Files          90       90              
  Lines        4190     4190              
  Branches      954      954              
==========================================
- Hits         3735     3734       -1     
- Misses        455      456       +1     
Impacted Files Coverage Δ
packages/core/src/domain/sessionManagement.ts 96.15% <50.00%> (-0.97%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32a5f92...8c7bc0b. Read the comment docs.

@bcaudan bcaudan marked this pull request as ready for review September 30, 2021 16:10
@bcaudan bcaudan requested a review from a team as a code owner September 30, 2021 16:10
@bcaudan bcaudan merged commit afb0b38 into main Oct 1, 2021
@bcaudan bcaudan deleted the bcaudan/plan-part6 branch October 1, 2021 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants