[RUMF-1045] rely on browser detection to check for innerText support #1110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcaudan
reviewed
Oct 5, 2021
Comment on lines
+1
to
+3
| export function isIE() { | ||
| return Boolean((document as any).documentMode) | ||
| } |
There was a problem hiding this comment.
Could we use this function for spec as well?
it could be nice to have a single isIE function in the code base
Codecov Report
@@ Coverage Diff @@
## main #1110 +/- ##
==========================================
- Coverage 88.22% 88.21% -0.02%
==========================================
Files 92 93 +1
Lines 4281 4275 -6
Branches 984 983 -1
==========================================
- Hits 3777 3771 -6
Misses 504 504
Continue to review full report at Codecov.
|
bcaudan
approved these changes
Oct 6, 2021
acorretti
approved these changes
Oct 6, 2021
bcaudan
deleted the
benoit/avoid-csp-warnings-when-computing-action-name
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The current solution to check for innerText accuracy (to see if it correctly removes
styleandscripttext content for computing action names) triggers CSP warnings.Changes
To avoid CSP warning, simply rely on browser detection.
Testing
CI
I have gone over the contributing documentation.