-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 [RUMF-1060] fix failing worker detection in Firefox #1139
Merged
amortemousque
merged 21 commits into
main
from
benoit/fix-failing-worker-detection-in-firefox
Oct 26, 2021
Merged
🐛 [RUMF-1060] fix failing worker detection in Firefox #1139
amortemousque
merged 21 commits into
main
from
benoit/fix-failing-worker-detection-in-firefox
Oct 26, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/rum/src/domain/segmentCollection/deflateWorkerSingleton.ts
Outdated
Show resolved
Hide resolved
packages/rum/src/domain/segmentCollection/deflateWorkerSingleton.ts
Outdated
Show resolved
Hide resolved
packages/rum/src/domain/segmentCollection/deflateWorkerSingleton.ts
Outdated
Show resolved
Hide resolved
bcaudan
reviewed
Oct 19, 2021
packages/rum/src/domain/segmentCollection/deflateWorkerSingleton.ts
Outdated
Show resolved
Hide resolved
packages/rum/src/domain/segmentCollection/deflateWorkerSingleton.ts
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #1139 +/- ##
==========================================
+ Coverage 89.16% 89.44% +0.27%
==========================================
Files 93 93
Lines 4201 4253 +52
Branches 962 972 +10
==========================================
+ Hits 3746 3804 +58
+ Misses 455 449 -6
Continue to review full report at Codecov.
|
bcaudan
reviewed
Oct 21, 2021
packages/rum/src/domain/segmentCollection/startDeflateWorker.spec.ts
Outdated
Show resolved
Hide resolved
packages/rum/src/domain/segmentCollection/startDeflateWorker.spec.ts
Outdated
Show resolved
Hide resolved
packages/rum/src/domain/segmentCollection/startDeflateWorker.spec.ts
Outdated
Show resolved
Hide resolved
packages/rum/src/domain/segmentCollection/startDeflateWorker.spec.ts
Outdated
Show resolved
Hide resolved
packages/rum/src/domain/segmentCollection/startDeflateWorker.spec.ts
Outdated
Show resolved
Hide resolved
packages/rum/src/domain/segmentCollection/startDeflateWorker.spec.ts
Outdated
Show resolved
Hide resolved
packages/rum/src/domain/segmentCollection/startDeflateWorker.spec.ts
Outdated
Show resolved
Hide resolved
amortemousque
force-pushed
the
benoit/fix-failing-worker-detection-in-firefox
branch
from
October 21, 2021 14:16
a703632
to
49acaf4
Compare
bcaudan
approved these changes
Oct 21, 2021
packages/rum/src/domain/segmentCollection/startDeflateWorker.spec.ts
Outdated
Show resolved
Hide resolved
packages/rum/src/domain/segmentCollection/startDeflateWorker.ts
Outdated
Show resolved
Hide resolved
packages/rum/src/domain/segmentCollection/startDeflateWorker.ts
Outdated
Show resolved
Hide resolved
acorretti
approved these changes
Oct 25, 2021
amortemousque
deleted the
benoit/fix-failing-worker-detection-in-firefox
branch
October 26, 2021 07:57
BenoitZugmeyer
restored the
benoit/fix-failing-worker-detection-in-firefox
branch
November 2, 2021 08:53
BenoitZugmeyer
deleted the
benoit/fix-failing-worker-detection-in-firefox
branch
November 2, 2021 10:06
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In Firefox, when the worker fails to instanciate because of CSP rules, it doesn't throw an error like Chromium does, but rather emits a
error
event asynchronously.Changes
error
events from the workerTesting
CI, manual
I have gone over the contributing documentation.