Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [RUMF-1062] fix support for Safari 11.0 #1154

Merged
merged 3 commits into from
Nov 8, 2021

Conversation

BenoitZugmeyer
Copy link
Member

Motivation

Fix Replay recorder support for Safari 11.0.

Changes

Replace FormData.set (see caniuse support) usages by FormData.append

Testing

Manual, staging.


I have gone over the contributing documentation.

@BenoitZugmeyer BenoitZugmeyer requested review from a team as code owners November 5, 2021 17:17
@codecov-commenter
Copy link

Codecov Report

Merging #1154 (bbd7b8f) into main (ff094d8) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1154   +/-   ##
=======================================
  Coverage   89.27%   89.27%           
=======================================
  Files          94       94           
  Lines        4204     4204           
  Branches      962      962           
=======================================
  Hits         3753     3753           
  Misses        451      451           
Impacted Files Coverage Δ
packages/rum/src/transport/send.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff094d8...bbd7b8f. Read the comment docs.

@BenoitZugmeyer BenoitZugmeyer merged commit 29ce163 into main Nov 8, 2021
@BenoitZugmeyer BenoitZugmeyer deleted the benoit/fix-support-for-safari-11 branch November 8, 2021 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants