🐛 [RUMF-1077] use cookies to get Synthetics context #1161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cookies + global variable should be enough/more reliable than the user agent which can be edited by the customer.
By using both global variable and cookies, the Synthetics context retrieval should be more reliable. We shouldn't need to check it every time we assemble an event. It should allow us to get it once at init, and keep the value locally so we don't need caching mechanism to access cookies and ensure good performances.
…-get-synthetics-context
| const resultId = (window as BrowserWindow)._DATADOG_SYNTHETICS_RESULT_ID | ||
| const testId = (window as BrowserWindow)._DATADOG_SYNTHETICS_PUBLIC_ID || getCookie(SYNTHETICS_TEST_ID_COOKIE_NAME) | ||
| const resultId = | ||
| (window as BrowserWindow)._DATADOG_SYNTHETICS_RESULT_ID || getCookie(SYNTHETICS_RESULT_ID_COOKIE_NAME) | ||
|
|
||
| if (typeof testId === 'string' && typeof resultId === 'string') { |
There was a problem hiding this comment.
if (typeof testId === 'string' && typeof resultId === 'string') {
Out of curiosity, what is this test for?
Is there any previous issue related to it?
There was a problem hiding this comment.
Mmh this test is a bit too preventive, indeed. I don't recall any issue where values where truthy without being a string. But I guess it's fine nonetheless?
amortemousque
approved these changes
Nov 12, 2021
bcaudan
approved these changes
Nov 15, 2021
BenoitZugmeyer
deleted the
benoit/use-cookies-to-get-synthetics-context
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
More reliable way to get Synthetics context on Selenium-based browsers (Firefox, IE)
Changes
Testing
I have gone over the contributing documentation.