Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [RUMF-1071] forward internal monitoring to bridge #1177

Merged
merged 13 commits into from
Dec 6, 2021

Conversation

amortemousque
Copy link
Contributor

@amortemousque amortemousque commented Nov 22, 2021

Motivation

The mobile SDKs (Android and iOS) want to track events that happen inside a webview using the browser SDK. The proposed way to do that is to inject a JS bridge interface that the browser SDK will call instead of sending the events to the intake.

This PR forward internal monitoring events when the bridge is present.

Changes

Forward internal monitoring event if bridge present

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2021

Codecov Report

Merging #1177 (b8235fb) into main (ca94e24) will decrease coverage by 0.01%.
The diff coverage is 94.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1177      +/-   ##
==========================================
- Coverage   88.97%   88.96%   -0.02%     
==========================================
  Files          99      100       +1     
  Lines        4281     4285       +4     
  Branches      969      970       +1     
==========================================
+ Hits         3809     3812       +3     
- Misses        472      473       +1     
Impacted Files Coverage Δ
packages/core/src/transport/eventBridge.ts 100.00% <ø> (ø)
.../domain/internalMonitoring/startMonitoringBatch.ts 81.81% <81.81%> (ø)
...rc/domain/internalMonitoring/internalMonitoring.ts 98.48% <100.00%> (ø)
packages/core/src/transport/httpRequest.ts 96.66% <100.00%> (ø)
...src/domain/segmentCollection/startDeflateWorker.ts 100.00% <100.00%> (ø)
packages/logs/src/domain/trackNetworkError.ts 88.88% <0.00%> (-3.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca94e24...b8235fb. Read the comment docs.

@amortemousque amortemousque marked this pull request as ready for review November 24, 2021 09:05
@amortemousque amortemousque requested review from a team as code owners November 24, 2021 09:05
@amortemousque amortemousque force-pushed the aymeric/forward-internal-monitoring-to-bridge branch from 866e423 to 82dc146 Compare November 24, 2021 14:58
@amortemousque amortemousque force-pushed the aymeric/forward-internal-monitoring-to-bridge branch from 70af7ee to 384a5b9 Compare November 25, 2021 12:49
@amortemousque amortemousque requested a review from a team as a code owner December 6, 2021 13:34
@amortemousque amortemousque merged commit 2287507 into main Dec 6, 2021
@amortemousque amortemousque deleted the aymeric/forward-internal-monitoring-to-bridge branch December 6, 2021 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants