-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ [RUMF-1071] forward internal monitoring to bridge #1177
Merged
amortemousque
merged 13 commits into
main
from
aymeric/forward-internal-monitoring-to-bridge
Dec 6, 2021
Merged
✨ [RUMF-1071] forward internal monitoring to bridge #1177
amortemousque
merged 13 commits into
main
from
aymeric/forward-internal-monitoring-to-bridge
Dec 6, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1177 +/- ##
==========================================
- Coverage 88.97% 88.96% -0.02%
==========================================
Files 99 100 +1
Lines 4281 4285 +4
Branches 969 970 +1
==========================================
+ Hits 3809 3812 +3
- Misses 472 473 +1
Continue to review full report at Codecov.
|
amortemousque
force-pushed
the
aymeric/forward-internal-monitoring-to-bridge
branch
from
November 24, 2021 14:58
866e423
to
82dc146
Compare
amortemousque
force-pushed
the
aymeric/forward-internal-monitoring-to-bridge
branch
from
November 25, 2021 12:49
70af7ee
to
384a5b9
Compare
bcaudan
reviewed
Nov 25, 2021
packages/core/src/domain/internalMonitoring/internalMonitoring.ts
Outdated
Show resolved
Hide resolved
bcaudan
approved these changes
Nov 29, 2021
BenoitZugmeyer
approved these changes
Nov 29, 2021
amortemousque
deleted the
aymeric/forward-internal-monitoring-to-bridge
branch
December 6, 2021 15:11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The mobile SDKs (Android and iOS) want to track events that happen inside a webview using the browser SDK. The proposed way to do that is to inject a JS bridge interface that the browser SDK will call instead of sending the events to the intake.
This PR forward internal monitoring events when the bridge is present.
Changes
Forward internal monitoring event if bridge present
Testing
I have gone over the contributing documentation.