Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ [RUMF-1083] rework session cookie cache #1180

Merged
merged 7 commits into from
Dec 9, 2021

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Nov 23, 2021

Motivation

Second part of session management rework, cf #1166

Next:

  • Introduce session context history

Changes

  • Remove cookie cache utility
  • Expose session through in memory cache
  • Watch cookie regularly to expire session

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

behavior changes:
- we consider the session expired when the store session is different from the cache session
- we don't expand a session that has not been active on the current tab
@bcaudan bcaudan marked this pull request as ready for review November 24, 2021 13:58
@bcaudan bcaudan requested a review from a team as a code owner November 24, 2021 13:58
@codecov-commenter
Copy link

Codecov Report

Merging #1180 (93d1dfb) into main (b955704) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1180      +/-   ##
==========================================
- Coverage   88.88%   88.87%   -0.02%     
==========================================
  Files         100      100              
  Lines        4283     4270      -13     
  Branches      970      971       +1     
==========================================
- Hits         3807     3795      -12     
+ Misses        476      475       -1     
Impacted Files Coverage Δ
packages/core/src/browser/cookie.ts 86.48% <ø> (-4.90%) ⬇️
...ges/core/src/domain/session/oldCookiesMigration.ts 100.00% <100.00%> (ø)
...kages/core/src/domain/session/sessionManagement.ts 100.00% <100.00%> (ø)
packages/core/src/domain/session/sessionStore.ts 100.00% <100.00%> (ø)
packages/logs/src/domain/trackNetworkError.ts 92.59% <0.00%> (+3.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b955704...93d1dfb. Read the comment docs.

@bcaudan bcaudan merged commit 6858d86 into main Dec 9, 2021
@bcaudan bcaudan deleted the bcaudan/rework-session_part-2 branch December 9, 2021 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants