-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ [RUMF-1083] rework session cookie cache #1180
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behavior changes: - we consider the session expired when the store session is different from the cache session - we don't expand a session that has not been active on the current tab
amortemousque
approved these changes
Nov 25, 2021
BenoitZugmeyer
approved these changes
Nov 26, 2021
4 tasks
Codecov Report
@@ Coverage Diff @@
## main #1180 +/- ##
==========================================
- Coverage 88.88% 88.87% -0.02%
==========================================
Files 100 100
Lines 4283 4270 -13
Branches 970 971 +1
==========================================
- Hits 3807 3795 -12
+ Misses 476 475 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Second part of session management rework, cf #1166
Next:
Changes
Testing
I have gone over the contributing documentation.