♻️ [RUMF-1097] revamp configuration - logs #1217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will help using a future "validateAndBuildConfiguration", and makes the Logs implementation closer to the RUM one.
So we can keep usages of LogsInitConfiguration inside the init() function
bcaudan
approved these changes
Dec 15, 2021
Comment on lines
-80
to
-84
| LOGS.init({ clientToken: 'yes', sampleRate: 'foo' as any }) | ||
| expect(displaySpy).toHaveBeenCalledTimes(1) | ||
|
|
||
| LOGS.init({ clientToken: 'yes', sampleRate: 200 }) | ||
| expect(displaySpy).toHaveBeenCalledTimes(2) |
There was a problem hiding this comment.
we have a test covering the 'foo' case in core but it does not seem that we still have one about '200'.
what about adding it to keep this case?
Codecov Report
@@ Coverage Diff @@
## main #1217 +/- ##
==========================================
- Coverage 89.08% 89.00% -0.09%
==========================================
Files 100 101 +1
Lines 4317 4321 +4
Branches 985 986 +1
==========================================
Hits 3846 3846
- Misses 471 475 +4
Continue to review full report at Codecov.
|
BenoitZugmeyer
force-pushed
the
benoit/revamp-configuration-logs
branch
from
9caed1c to
283cd91
Compare
4 tasks
amortemousque
approved these changes
Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Followup of #1216 . This PR focuses on the logs part.
Changes
logs/src/domain/configurationmoduleLogsConfigurationto be used internally in the Logs SDKinit(), by using the previously introducedvalidateAndBuildConfigurationfunction fromcoreforwardErrorToLogstoLogsConfiguration, to avoid usingInitConfigurationoutside ofinit()Testing
I have gone over the contributing documentation.