-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ [RUMF-1109] Add event rate limiters for loggers #1243
Merged
amortemousque
merged 5 commits into
main
from
aymeric/add-event-rate-limiters-for-loggers
Jan 7, 2022
Merged
✨ [RUMF-1109] Add event rate limiters for loggers #1243
amortemousque
merged 5 commits into
main
from
aymeric/add-event-rate-limiters-for-loggers
Jan 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcaudan
reviewed
Jan 5, 2022
amortemousque
force-pushed
the
aymeric/add-event-rate-limiters-for-loggers
branch
from
January 6, 2022 15:00
331753d
to
ef30f88
Compare
BenoitZugmeyer
approved these changes
Jan 6, 2022
Codecov Report
@@ Coverage Diff @@
## main #1243 +/- ##
=======================================
Coverage 89.13% 89.13%
=======================================
Files 104 104
Lines 4253 4253
Branches 960 961 +1
=======================================
Hits 3791 3791
Misses 462 462
Continue to review full report at Codecov.
|
bcaudan
reviewed
Jan 7, 2022
bcaudan
approved these changes
Jan 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To be consistent and to prevent any spamming from users we limit logger.debug|info|warn APIs.
Changes
Add event rate limiters for logger.debug|info|warn
Testing
I have gone over the contributing documentation.