Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [RUMF-1109] Add event rate limiters for loggers #1243

Merged
merged 5 commits into from
Jan 7, 2022

Conversation

amortemousque
Copy link
Contributor

Motivation

To be consistent and to prevent any spamming from users we limit logger.debug|info|warn APIs.

Changes

Add event rate limiters for logger.debug|info|warn

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@amortemousque amortemousque requested a review from a team as a code owner January 4, 2022 17:00
packages/logs/src/domain/configuration.ts Outdated Show resolved Hide resolved
packages/logs/src/boot/startLogs.ts Outdated Show resolved Hide resolved
@amortemousque amortemousque force-pushed the aymeric/add-event-rate-limiters-for-loggers branch from 331753d to ef30f88 Compare January 6, 2022 15:00
@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2022

Codecov Report

Merging #1243 (a17bcbd) into main (b801158) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1243   +/-   ##
=======================================
  Coverage   89.13%   89.13%           
=======================================
  Files         104      104           
  Lines        4253     4253           
  Branches      960      961    +1     
=======================================
  Hits         3791     3791           
  Misses        462      462           
Impacted Files Coverage Δ
...ges/core/src/domain/configuration/configuration.ts 100.00% <ø> (ø)
packages/rum-core/src/domain/assembly.ts 100.00% <ø> (ø)
packages/rum-core/src/domain/configuration.ts 95.45% <ø> (ø)
packages/logs/src/boot/startLogs.ts 86.66% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b801158...a17bcbd. Read the comment docs.

packages/logs/src/boot/startLogs.spec.ts Outdated Show resolved Hide resolved
packages/logs/src/boot/startLogs.spec.ts Outdated Show resolved Hide resolved
packages/logs/src/boot/startLogs.spec.ts Outdated Show resolved Hide resolved
@amortemousque amortemousque merged commit eecd96d into main Jan 7, 2022
@amortemousque amortemousque deleted the aymeric/add-event-rate-limiters-for-loggers branch January 7, 2022 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants