Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [RUMF-1143] make sure to drop LCP timings if the page was previously hidden #1259

Merged
merged 2 commits into from
Jan 10, 2022

Conversation

BenoitZugmeyer
Copy link
Member

@BenoitZugmeyer BenoitZugmeyer commented Jan 10, 2022

Motivation

#1256

Changes

Also listen for VISIBILITY_CHANGE when tracking the first time a page is hidden. PAGE_HIDE alone is not sufficient.

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@BenoitZugmeyer BenoitZugmeyer changed the title 🐛 [RUMF-1143] fix trackFirstHidden 🐛 [RUMF-1143] make sure to drop LCP timings if the page was previously hidden Jan 10, 2022
@BenoitZugmeyer BenoitZugmeyer merged commit 423c1c6 into main Jan 10, 2022
@BenoitZugmeyer BenoitZugmeyer deleted the benoit/fix-track-first-hidden branch January 10, 2022 16:29
BenoitZugmeyer added a commit that referenced this pull request Jan 11, 2022
* 🐛 [RUMF-1143] fix trackFirstHidden (#1259)

* update v3 references across the codebase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants