[RUMF-1176] collect other console logs new

packages/core/src/browser/consoleObservable.ts

@@ -14,8 +14,6 @@ export const ConsoleApiName = {
 
 export type ConsoleApiName = typeof ConsoleApiName[keyof typeof ConsoleApiName]
 
-export const CONSOLE_APIS = Object.keys(ConsoleApiName) as ConsoleApiName[]
-
 export interface ConsoleLog {
   message: string
   api: ConsoleApiName

packages/core/src/index.ts

@@ -55,7 +55,7 @@ export { Context, ContextArray, ContextValue } from './tools/context'
 export { areCookiesAuthorized, getCookie, setCookie, deleteCookie, COOKIE_ACCESS_DELAY } from './browser/cookie'
 export { initXhrObservable, XhrCompleteContext, XhrStartContext } from './browser/xhrObservable'
 export { initFetchObservable, FetchCompleteContext, FetchStartContext, FetchContext } from './browser/fetchObservable'
-export { initConsoleObservable, ConsoleLog, ConsoleApiName, CONSOLE_APIS } from './browser/consoleObservable'
+export { initConsoleObservable, ConsoleLog, ConsoleApiName } from './browser/consoleObservable'
 export { BoundedBuffer } from './tools/boundedBuffer'
 export { catchUserErrors } from './tools/catchUserErrors'
 export { createContextManager } from './tools/contextManager'

packages/logs/src/domain/configuration.spec.ts

@@ -1,4 +1,4 @@
-import { CONSOLE_APIS, display, resetExperimentalFeatures, updateExperimentalFeatures } from '@datadog/browser-core'
+import { ConsoleApiName, display, resetExperimentalFeatures, updateExperimentalFeatures } from '@datadog/browser-core'
 import { validateAndBuildLogsConfiguration } from './configuration'
 
 const DEFAULT_INIT_CONFIGURATION = { clientToken: 'xxx' }
@@ -28,6 +28,7 @@ describe('validateAndBuildLogsConfiguration', () => {
     let displaySpy: jasmine.Spy<typeof display.error>
     const errorMessage =
       'Forward Console Logs should be "all" or an array with allowed values "log", "debug", "info", "warn", "error"'
+
     beforeEach(() => {
       displaySpy = spyOn(display, 'error')
       updateExperimentalFeatures(['forward-logs'])
@@ -71,7 +72,7 @@ describe('validateAndBuildLogsConfiguration', () => {
       expect(
         validateAndBuildLogsConfiguration({ ...DEFAULT_INIT_CONFIGURATION, forwardConsoleLogs: 'all' })!
           .forwardConsoleLogs
-      ).toEqual(CONSOLE_APIS)
+      ).toEqual(Object.keys(ConsoleApiName) as ConsoleApiName[])
     })
   })
 

packages/logs/src/domain/configuration.ts

@@ -6,7 +6,6 @@ import {
   isExperimentalFeatureEnabled,
   removeDuplicates,
   ConsoleApiName,
-  CONSOLE_APIS,
   includes,
 } from '@datadog/browser-core'
 import { buildEnv } from '../boot/buildEnv'
@@ -40,23 +39,24 @@ export function validateAndBuildLogsConfiguration(
     return
   }
 
+  const allowedConsoleApis = Object.keys(ConsoleApiName) as ConsoleApiName[]
   let forwardConsoleLogs: StatusType[] = []
   if (isExperimentalFeatureEnabled('forward-logs') && initConfiguration.forwardConsoleLogs !== undefined) {
     if (
       (initConfiguration.forwardConsoleLogs !== 'all' && !Array.isArray(initConfiguration.forwardConsoleLogs)) ||
       (Array.isArray(initConfiguration.forwardConsoleLogs) &&
-        initConfiguration.forwardConsoleLogs.some((api) => !includes(CONSOLE_APIS, api)))
+        initConfiguration.forwardConsoleLogs.some((api) => !includes(allowedConsoleApis, api)))
     ) {
       display.error(
-        `Forward Console Logs should be "all" or an array with allowed values ${CONSOLE_APIS.map(
-          (api) => `"${api}"`
-        ).join(', ')}`
+        `Forward Console Logs should be "all" or an array with allowed values ${allowedConsoleApis
+          .map((api) => `"${api}"`)
+          .join(', ')}`
       )
       return
     }
 
     forwardConsoleLogs =
-      initConfiguration.forwardConsoleLogs === 'all' ? CONSOLE_APIS : initConfiguration.forwardConsoleLogs
+      initConfiguration.forwardConsoleLogs === 'all' ? allowedConsoleApis : initConfiguration.forwardConsoleLogs
   }
 
   if (initConfiguration.forwardErrorsToLogs) {