Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ [RUMF-1177] add index_in_view to segment meta #1342

Merged
merged 9 commits into from
Feb 16, 2022
Merged

✨ [RUMF-1177] add index_in_view to segment meta #1342

merged 9 commits into from
Feb 16, 2022

Conversation

BenoitZugmeyer
Copy link
Member

@BenoitZugmeyer BenoitZugmeyer commented Feb 15, 2022 •
edited
Loading

Motivation

Helps debugging replay issues

Changes

Add a segment.meta.index_in_view field to the segment structure. This is also sent to the intake as a index_in_view FormData field.

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@BenoitZugmeyer BenoitZugmeyer requested review from a team as code owners February 15, 2022 16:26
ThibautGeriz
ThibautGeriz approved these changes Feb 15, 2022
View reviewed changes
Copy link
Contributor

@ThibautGeriz ThibautGeriz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for replay

bcaudan
bcaudan approved these changes Feb 16, 2022
View reviewed changes
packages/rum/src/domain/replayStats.ts Outdated Show resolved Hide resolved
packages/rum/src/types.ts Outdated Show resolved Hide resolved
@BenoitZugmeyer BenoitZugmeyer changed the title ✨ [RUMF-1177] add sequence_number to segment meta ✨ [RUMF-1177] add index_in_view to segment meta Feb 16, 2022
@BenoitZugmeyer BenoitZugmeyer merged commit 8e245c3 into main Feb 16, 2022
@BenoitZugmeyer BenoitZugmeyer deleted the benoit/segment-sequence-numbers branch February 16, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amortemousque amortemousque amortemousque approved these changes

@acorretti acorretti acorretti left review comments

@ThibautGeriz ThibautGeriz ThibautGeriz approved these changes

@bcaudan bcaudan bcaudan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BenoitZugmeyer @acorretti @bcaudan @amortemousque @ThibautGeriz