🔥 [RUMF-1198] remove problematic and useless code from the DeflateWorker #1378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I needed to reformat some comments to comply with the line size limit. While those comments are cryptic and probably not helpful for us, they are present in Pako source code. I chose to keep them, but maybe we could remove them instead.
This commit removes the ability to pass options to the `Deflate` class. It's fine, because we never do. This allows to remove some problematic "helper" functions causing issues when customers are transpiling the RUM package with babel.
BenoitZugmeyer
force-pushed
the
benoit/remove-typeof-from-deflate-worker
branch
from
f4aa639 to
407ae76
Compare
amortemousque
approved these changes
Mar 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In some cases, where a Browser SDK user is using babel on their dependencies, it can lead to a broken Session Replay recorder because some helpers inserted by Babel are not accessible in the worker.
Changes
Testing
I have gone over the contributing documentation.