Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📦 [RUMF-1162] update developer-extension #1379

Merged
merged 6 commits into from
Mar 8, 2022
Merged

Conversation

BenoitZugmeyer
Copy link
Member

@BenoitZugmeyer BenoitZugmeyer commented Mar 7, 2022

Motivation

Keep dependencies up to date and maintanable

Changes

  • Replace bumbag with mantine.
    • Reasons:
    • Why mantine:
      • Very similar to bumbag (uses same dependencies (emotion), provides the same components), so upgrade is easy
      • Lots more traction (6.5k stars on github, vs 971 for bumbag)
  • Adjust the extension codebase to comply with stryctNullChecks
  • Update react and types

The webpack plugins used by the extension has not been updated. This will be done in a future task where we update webpack.

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@BenoitZugmeyer BenoitZugmeyer requested a review from a team as a code owner March 7, 2022 10:24
@BenoitZugmeyer BenoitZugmeyer merged commit 275f807 into main Mar 8, 2022
@BenoitZugmeyer BenoitZugmeyer deleted the benoit/update-react branch March 8, 2022 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants