-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Allow update service version with start view #1448
Merged
amortemousque
merged 10 commits into
main
from
aymeric/Allow-update-service-version-with-startView
Mar 30, 2022
Merged
✨ Allow update service version with start view #1448
amortemousque
merged 10 commits into
main
from
aymeric/Allow-update-service-version-with-startView
Mar 30, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amortemousque
force-pushed
the
aymeric/Allow-update-service-version-with-startView
branch
from
March 28, 2022 15:03
722b1e2
to
63368dc
Compare
Codecov Report
@@ Coverage Diff @@
## main #1448 +/- ##
==========================================
+ Coverage 89.89% 89.93% +0.04%
==========================================
Files 107 107
Lines 4293 4301 +8
Branches 954 957 +3
==========================================
+ Hits 3859 3868 +9
+ Misses 434 433 -1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
BenoitZugmeyer
approved these changes
Mar 28, 2022
amortemousque
deleted the
aymeric/Allow-update-service-version-with-startView
branch
March 30, 2022 14:38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In the context of sub-apps, web and mobile developers want to only see RUM events happening in their area of ownership. For example, a developer working on the Log Management product at Datadog wants to see RUM events that happened in the Log Management only. To do so we will make the service attribute first-class-citizen in RUM and allow customers to update the current service and version.
This PR allow the user to update the service and the version during the lifespan of a session with the startView API
Changes
Update startView API
Remove service and version tags
Testing
I have gone over the contributing documentation.