Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Allow update service version with start view #1448

Merged

Conversation

amortemousque
Copy link
Contributor

@amortemousque amortemousque commented Mar 24, 2022

Motivation

In the context of sub-apps, web and mobile developers want to only see RUM events happening in their area of ownership. For example, a developer working on the Log Management product at Datadog wants to see RUM events that happened in the Log Management only. To do so we will make the service attribute first-class-citizen in RUM and allow customers to update the current service and version.

This PR allow the user to update the service and the version during the lifespan of a session with the startView API

Changes

Update startView API
Remove service and version tags

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@amortemousque amortemousque requested a review from a team as a code owner March 24, 2022 15:32
packages/rum-core/src/boot/rumPublicApi.ts Outdated Show resolved Hide resolved
packages/rum-core/src/boot/rumPublicApi.ts Outdated Show resolved Hide resolved
packages/rum-core/src/domain/assembly.spec.ts Outdated Show resolved Hide resolved
packages/rum-core/src/domain/assembly.spec.ts Outdated Show resolved Hide resolved
@amortemousque amortemousque force-pushed the aymeric/Allow-update-service-version-with-startView branch from 722b1e2 to 63368dc Compare March 28, 2022 15:03
@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2022

Codecov Report

Merging #1448 (493feb7) into main (68161f5) will increase coverage by 0.04%.
The diff coverage is 96.29%.

@@            Coverage Diff             @@
##             main    #1448      +/-   ##
==========================================
+ Coverage   89.89%   89.93%   +0.04%     
==========================================
  Files         107      107              
  Lines        4293     4301       +8     
  Branches      954      957       +3     
==========================================
+ Hits         3859     3868       +9     
+ Misses        434      433       -1     
Impacted Files Coverage Δ
packages/rum-core/src/boot/startRum.ts 22.22% <0.00%> (ø)
packages/rum-core/src/domain/configuration.ts 95.45% <ø> (ø)
packages/rum-core/src/domain/viewContexts.ts 100.00% <ø> (ø)
packages/rum-core/src/boot/rumPublicApi.ts 94.79% <100.00%> (+0.05%) ⬆️
packages/rum-core/src/domain/assembly.ts 100.00% <100.00%> (ø)
.../src/domain/rumEventsCollection/view/trackViews.ts 98.03% <100.00%> (+0.08%) ⬆️
.../domain/rumEventsCollection/view/viewCollection.ts 100.00% <100.00%> (ø)
packages/core/src/tools/timeUtils.ts 100.00% <0.00%> (+2.85%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@amortemousque amortemousque merged commit cb1918e into main Mar 30, 2022
@amortemousque amortemousque deleted the aymeric/Allow-update-service-version-with-startView branch March 30, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants