🐛 Adjust records generated during view change so their date matches the view date #1486
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, when a new view is generated we get the current timestamp to define the view date.
Then we take a full snapshot, which consists in 3-4 records every time a record is emitted, we get the current timestamp to define its date
This causes an issue during replay, when seeking: when the user clicks on a View event, the player actually shows the previous view, because the records corresponding to the new view are a few milliseconds after the view start.
This PR set the view date to the fullsnapshot emitted records when a view change
Changes
Set the view date to the fullsnapshot emitted records when a view change
Testing
I have gone over the contributing documentation.