Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [RUMF-1214] implement frustration signals counters #1511

Merged
merged 3 commits into from
May 6, 2022

Conversation

BenoitZugmeyer
Copy link
Member

@BenoitZugmeyer BenoitZugmeyer commented Apr 25, 2022

Motivation

Count the number of frustration occuring during a view

Changes

  • Do a bit of renaming, userAction are now action
  • Implement the counter

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@BenoitZugmeyer BenoitZugmeyer requested a review from a team as a code owner April 25, 2022 15:13
@BenoitZugmeyer BenoitZugmeyer marked this pull request as draft April 25, 2022 15:14
@BenoitZugmeyer BenoitZugmeyer force-pushed the benoit/frustration-signals-counters branch from 0e7bfea to d169928 Compare April 25, 2022 15:17
@BenoitZugmeyer BenoitZugmeyer force-pushed the benoit/frustration-signals-counters branch from d169928 to 50b1f90 Compare April 29, 2022 14:38
@BenoitZugmeyer BenoitZugmeyer marked this pull request as ready for review April 29, 2022 14:57
@codecov-commenter
Copy link

Codecov Report

Merging #1511 (1fec59b) into main (06645dc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1511   +/-   ##
=======================================
  Coverage   90.22%   90.22%           
=======================================
  Files         114      114           
  Lines        4358     4360    +2     
  Branches      972      973    +1     
=======================================
+ Hits         3932     3934    +2     
  Misses        426      426           
Impacted Files Coverage Δ
...omain/rumEventsCollection/view/trackViewMetrics.ts 100.00% <ø> (ø)
.../domain/rumEventsCollection/view/viewCollection.ts 100.00% <ø> (ø)
packages/rum-core/test/fixtures.ts 100.00% <ø> (ø)
packages/rum-core/src/domain/trackEventCounts.ts 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@BenoitZugmeyer BenoitZugmeyer merged commit 637b081 into main May 6, 2022
@BenoitZugmeyer BenoitZugmeyer deleted the benoit/frustration-signals-counters branch May 6, 2022 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants