⚗️✨ [RUMF-1258] stop ongoing action on view end #1528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By allowing multiple `onStop` callbacks, we can simplify the click processing logic a bit. This will also allow us to invoke `click.stop` with an `endTime` in a future commit.
BenoitZugmeyer
force-pushed
the
benoit/stop-action-on-view-end
branch
from
ebe25e6 to
af79d16
Compare
Codecov Report
@@ Coverage Diff @@
## main #1528 +/- ##
==========================================
+ Coverage 90.33% 90.37% +0.04%
==========================================
Files 115 115
Lines 4447 4446 -1
Branches 996 993 -3
==========================================
+ Hits 4017 4018 +1
+ Misses 430 428 -2
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
packages/rum-core/src/domain/rumEventsCollection/action/trackClickActions.ts
Outdated
Show resolved
Hide resolved
amortemousque
approved these changes
May 13, 2022
bcaudan
approved these changes
May 13, 2022
BenoitZugmeyer
force-pushed
the
benoit/stop-action-on-view-end
branch
from
c0e05e5 to
b364bbe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Having actions spaning on multiple views is a bit weird.
Changes
Testing
I have gone over the contributing documentation.