Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Rename Replay plan to Premium plan #1534

Merged
merged 7 commits into from
May 17, 2022
Merged

Conversation

MirandaKapin
Copy link
Contributor

@MirandaKapin MirandaKapin commented May 16, 2022

Motivation

New premium plan name to reduce confusion between replay feature and replay plan.

Changes

  • introduce premiumSampleRate option and deprecate replaySampleRate
  • rename replay plan occurrences to premium

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

Updated the places with the old "Session Replay" SKU name to be "RUM Premium"
@MirandaKapin MirandaKapin requested review from a team as code owners May 16, 2022 04:15
@MirandaKapin MirandaKapin requested a review from a team as a code owner May 16, 2022 15:48
@bcaudan bcaudan changed the title Update RUM with RUM Premium naming ✨ Rename Replay plan to Premium plan May 16, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1534 (bd9f87f) into main (3a004b2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1534   +/-   ##
=======================================
  Coverage   90.48%   90.49%           
=======================================
  Files         116      116           
  Lines        4478     4480    +2     
  Branches     1004     1005    +1     
=======================================
+ Hits         4052     4054    +2     
  Misses        426      426           
Impacted Files Coverage Δ
packages/rum-core/src/domain/assembly.ts 100.00% <100.00%> (ø)
packages/rum-core/src/domain/configuration.ts 96.66% <100.00%> (+0.23%) ⬆️
packages/rum-core/src/domain/rumSessionManager.ts 88.23% <100.00%> (ø)
packages/rum-core/test/mockRumSessionManager.ts 100.00% <100.00%> (ø)
packages/rum/src/boot/recorderApi.ts 95.91% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@maycmlee maycmlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for docs.

@bcaudan bcaudan merged commit 431876e into main May 17, 2022
@bcaudan bcaudan deleted the MirandaKapin/RUMPremium branch May 17, 2022 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants