✨ [RUMF-1262] ignore some URLs when watching the page activity #1536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenoitZugmeyer
force-pushed
the
benoit/excluded-activity-urls
branch
from
a38c2a3 to
72720df
Compare
Codecov Report
@@ Coverage Diff @@
## main #1536 +/- ##
==========================================
+ Coverage 90.48% 90.51% +0.02%
==========================================
Files 116 116
Lines 4478 4489 +11
Branches 1004 1011 +7
==========================================
+ Hits 4052 4063 +11
Misses 426 426
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
More details will be written in a separate document.
cswatt
approved these changes
May 17, 2022
bcaudan
approved these changes
May 18, 2022
| @@ -631,3 +631,7 @@ export function removeDuplicates<T>(array: T[]) { | |||
| array.forEach((item) => set.add(item)) | |||
| return setToArray(set) | |||
| } | |||
|
|
|||
| export function matchList(list: Array<string | RegExp>, value: string) { | |||
amortemousque
approved these changes
May 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Some resources are interfering when watching the page activity:
Changes
Add an option to ignore some resources when computing the page activity
Testing
I have gone over the contributing documentation.