Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ [RUMF-1190] cleanup telemetry #1560

Merged
merged 8 commits into from
May 24, 2022
Merged

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented May 23, 2022

Motivation

As telemetry has been successfully enabled, remove the legacy system and do some cleanup.

Changes

  • remove legacy internal monitoring
  • remove telemetry feature flag
  • rename internal monitoring references to telemetry

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@codecov-commenter
Copy link

codecov-commenter commented May 23, 2022

Codecov Report

Merging #1560 (faa2e2a) into main (0d83f9c) will increase coverage by 0.21%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##             main    #1560      +/-   ##
==========================================
+ Coverage   90.50%   90.71%   +0.21%     
==========================================
  Files         118      118              
  Lines        4496     4461      -35     
  Branches     1014     1000      -14     
==========================================
- Hits         4069     4047      -22     
+ Misses        427      414      -13     
Impacted Files Coverage Δ
packages/core/src/boot/init.ts 84.61% <ø> (ø)
packages/core/src/browser/fetchObservable.ts 95.34% <ø> (ø)
packages/core/src/browser/xhrObservable.ts 98.03% <ø> (ø)
...ges/core/src/domain/configuration/configuration.ts 100.00% <ø> (ø)
...kages/core/src/domain/console/consoleObservable.ts 100.00% <ø> (ø)
...ackages/core/src/domain/report/reportObservable.ts 97.36% <ø> (ø)
...ages/core/src/domain/session/sessionCookieStore.ts 100.00% <ø> (ø)
packages/core/src/domain/session/sessionManager.ts 100.00% <ø> (ø)
packages/core/src/domain/session/sessionStore.ts 100.00% <ø> (ø)
packages/core/src/tools/error.ts 90.62% <ø> (ø)
... and 14 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@bcaudan bcaudan force-pushed the bcaudan/telemetry-cleanup branch from 444f782 to 28874ac Compare May 23, 2022 15:45
@bcaudan bcaudan force-pushed the bcaudan/telemetry-cleanup branch from 28874ac to 960971e Compare May 23, 2022 15:46
@bcaudan bcaudan marked this pull request as ready for review May 23, 2022 15:55
@bcaudan bcaudan requested review from a team as code owners May 23, 2022 15:55
@bcaudan bcaudan merged commit 4713059 into main May 24, 2022
@bcaudan bcaudan deleted the bcaudan/telemetry-cleanup branch May 24, 2022 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants