Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 [RUMF-1273] fix BUILD_MODE scope #1627

Merged
merged 1 commit into from
Jul 4, 2022
Merged

🐛 [RUMF-1273] fix BUILD_MODE scope #1627

merged 1 commit into from
Jul 4, 2022

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Jul 4, 2022 •
edited
Loading

Motivation

Following #1614, mutualizing BUILD_MODE make it unavailable from scripts 🤦‍♂️

Changes

promote BUILD_MODE as an env variable

Testing

  • ci

I have gone over the contributing documentation.

@bcaudan
🐛 [RUMF-1273] fix BUILD_MODE scope
6498aa4 
BUILD_MODE not accessible from scripts, put it as an env variable then
@bcaudan bcaudan marked this pull request as ready for review July 4, 2022 13:59
@bcaudan bcaudan requested a review from a team as a code owner July 4, 2022 13:59
@bcaudan bcaudan merged commit 13dc814 into main Jul 4, 2022
@bcaudan bcaudan deleted the bcaudan/fix-sci branch July 4, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amortemousque amortemousque amortemousque approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bcaudan @amortemousque