-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 [RUMF-1327] rum synthetics: fix logs session conflict #1629
🐛 [RUMF-1327] rum synthetics: fix logs session conflict #1629
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
// Duration to create a cookie lasting at least until the end of the test | ||
const COOKIE_DURATION = ONE_MINUTE | ||
|
||
export function mockSyntheticsWorkerValues( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 praise: nice job lifting this, I feel this file is a little long
Motivation
We identified an issue when the RUM SDK is injected by the Synthetics Worker and the Web application is using the Logs SDK: cookie options might be different, and the session cookie accesses have unexpected behaviors.
Changes
To avoid that, this PR makes sure that the Logs SDK does not create a cookie session when the RUM SDK will be injected by the Synthetics Worker
In this context, the Logs SDK will rely on the session created by the inject RUM SDK
Testing
I have gone over the contributing documentation.