Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [RUMF-1327] rum synthetics: fix logs session conflict #1629

Merged

Conversation

BenoitZugmeyer
Copy link
Member

@BenoitZugmeyer BenoitZugmeyer commented Jul 6, 2022

Motivation

We identified an issue when the RUM SDK is injected by the Synthetics Worker and the Web application is using the Logs SDK: cookie options might be different, and the session cookie accesses have unexpected behaviors.

Changes

To avoid that, this PR makes sure that the Logs SDK does not create a cookie session when the RUM SDK will be injected by the Synthetics Worker

In this context, the Logs SDK will rely on the session created by the inject RUM SDK

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@BenoitZugmeyer BenoitZugmeyer marked this pull request as ready for review July 6, 2022 10:18
@BenoitZugmeyer BenoitZugmeyer requested a review from a team as a code owner July 6, 2022 10:18
Copy link
Contributor

@bcaudan bcaudan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👍

Copy link
Contributor

@liywjl liywjl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

// Duration to create a cookie lasting at least until the end of the test
const COOKIE_DURATION = ONE_MINUTE

export function mockSyntheticsWorkerValues(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 praise: nice job lifting this, I feel this file is a little long

packages/logs/src/domain/assembly.ts Outdated Show resolved Hide resolved
@BenoitZugmeyer BenoitZugmeyer merged commit 3c059f0 into main Jul 7, 2022
@BenoitZugmeyer BenoitZugmeyer deleted the benoit/rum-synthetics--fix-logs-session-conflict branch July 7, 2022 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants